Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save versioned segment overrides #4892

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Dec 4, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Combining segment and value change requests in a single request brought up a bug in saving segment overrides where applied logic as if it was attempting to schedule them - this is because button presses send a truthy value by default.

              const saveFeatureSegments = saveFeatureWithValidation(
                (schedule) => {...}

How did you test this code?

Removed / added / adjusted segment overrides on a versioned environment

@kyle-ssg kyle-ssg requested a review from a team as a code owner December 4, 2024 15:55
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team December 4, 2024 15:55
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 3:55pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 3:55pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Dec 4, 2024 3:55pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4892 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4892 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4892 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4892 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4892 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4892 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Uffizzi Preview deployment-58822 was deleted.

@kyle-ssg kyle-ssg merged commit f5e3410 into main Dec 4, 2024
30 checks passed
@kyle-ssg kyle-ssg deleted the fix/save-versioned-segment-overrides branch December 4, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants