Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(my-permissions): Add tag based permissions #4824

Merged
merged 2 commits into from
Nov 12, 2024
Merged

feat(my-permissions): Add tag based permissions #4824

merged 2 commits into from
Nov 12, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Nov 11, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Bump RBAC version to fix #4813

How did you test this code?

Tests are implement here: https://github.com/Flagsmith/flagsmith-rbac/pull/28

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 0:17am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 0:17am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 0:17am

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Nov 11, 2024
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Uffizzi Preview deployment-58142 was deleted.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.33%. Comparing base (e6f1bac) to head (495de0d).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4824   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files        1180     1180           
  Lines       41223    41231    +8     
=======================================
+ Hits        40123    40131    +8     
  Misses       1100     1100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi
Copy link
Member Author

@github-actions github-actions bot removed the feature New feature or request label Nov 11, 2024
@github-actions github-actions bot added the feature New feature or request label Nov 11, 2024
@gagantrivedi gagantrivedi marked this pull request as ready for review November 11, 2024 12:19
@gagantrivedi gagantrivedi requested a review from a team as a code owner November 11, 2024 12:19
@gagantrivedi gagantrivedi requested review from matthewelwell and a team and removed request for a team November 11, 2024 12:19
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Nov 11, 2024
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4824 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4824 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4824 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4824 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4824 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4824 Finished ✅ Results

@gagantrivedi gagantrivedi merged commit cbd60d9 into main Nov 12, 2024
54 checks passed
@gagantrivedi gagantrivedi deleted the fix/4813 branch November 12, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return tags in /my-permission
2 participants