Skip to content

Commit

Permalink
update to FixedEffectModels 1.5 (#42)
Browse files Browse the repository at this point in the history
* update to FixedEffectModels 1.5

* Update fit.jl

* Update Project.toml
  • Loading branch information
matthieugomez authored Apr 12, 2021
1 parent 12ae624 commit 7864843
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ src/other/*
*.log
*.out
*.synctex.gz
examples/runbenchmark.jl
examples/runbenchmark.jl
.DS_Store
8 changes: 4 additions & 4 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "InteractiveFixedEffectModels"
uuid = "80307280-efb2-5c5d-af8b-a9c15821677b"
version = "1.1.1"
version = "1.1.2"

[deps]
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
Expand All @@ -20,11 +20,11 @@ Vcov = "ec2bfdc2-55df-4fc9-b9ae-4958c2cf2486"

[compat]
DataFrames = "0.21, 0.22"
FillArrays = "0.7, 0.8, 0.9, 0.10"
FixedEffectModels = "1.3"
FillArrays = "0.7, 0.8, 0.9, 0.10, 0.11"
FixedEffectModels = "1.5"
FixedEffects = "2"
LeastSquaresOptim = "0.7, 0.8"
Reexport = "0.2"
Reexport = "0.2, 1.0"
StatsBase = "0.33"
StatsModels = "0.6"
StatsFuns = "0.9"
Expand Down
2 changes: 1 addition & 1 deletion src/fit.jl
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ function regife(
Symbol(fesymbol(a)) factor_vars && error("FixedEffect should correspond to id or time dimension of the factor model")
end
end
fes, ids, formula = FixedEffectModels.parse_fixedeffect(df, formula)
fes, ids, fekeys, formula = FixedEffectModels.parse_fixedeffect(df, formula)
has_fes = !isempty(fes)
has_fes_intercept = false
## Compute factors, an array of AbtractFixedEffects
Expand Down

2 comments on commit 7864843

@matthieugomez
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/34114

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.1.2 -m "<description of version>" 78648430bf50ec71f0a27cabfde7366407ebbd3c
git push origin v1.1.2

Please sign in to comment.