Dependency cleanup and updates

[cafca]

Remove unused dependencies, upgrade to Webpack 5 and solve numerous problems
surfacing because of that.

Todo

• Webpack Dev Server works
• Build works
• Fix unit tests
• Fix Cypress tests

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[codecov]

Codecov Report

Merging #912 (676f73b) into develop (767cca4) will decrease coverage by 1.10%.
The diff coverage is 41.02%.

@@             Coverage Diff             @@
##           develop     #912      +/-   ##
===========================================
- Coverage    37.16%   36.06%   -1.11%     
===========================================
  Files          458      458              
  Lines         9321     9112     -209     
  Branches      2501     2017     -484     
===========================================
- Hits          3464     3286     -178     
+ Misses        5551     5376     -175     
- Partials       306      450     +144     

Flag	Coverage Δ
unittests	36.06% <41.02%> (-1.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/App.tsx	0.00% <0.00%> (ø)
src/apps/Gastro/components/FileUpload.tsx	75.00% <ø> (-3.58%)	⬇️
...apps/Gastro/components/RegistrationForm/Direct.tsx	0.00% <ø> (ø)
...components/RegistrationForm/SectionCertificate.tsx	0.00% <0.00%> (ø)
...stro/components/RegistrationForm/SectionNotice.tsx	0.00% <0.00%> (ø)
.../apps/Gastro/components/RegistrationForm/index.tsx	0.00% <ø> (ø)
src/apps/Gastro/components/SignupForm/index.tsx	0.00% <ø> (ø)
src/apps/Gastro/components/ThanksRegistration.tsx	0.00% <0.00%> (ø)
src/apps/Gastro/pages/EventApplication.tsx	0.00% <0.00%> (ø)
src/apps/Gastro/pages/Events/Application.tsx	0.00% <0.00%> (ø)
... and 260 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 767cca4...676f73b. Read the comment docs.

[cafca]

This is something that @ohrie and @tordans could make a decision on

[ohrie]

I am for this option.
Specifically I would prefer this scheme for default exports:

const ComponentA = (props) => {
  return <div>{props.header}</div>;
};

export default ComponentA;

How about you, @tordans ?

[tordans]

@ohrie in https://github.com/FixMyBerlin/fixmy.rsv/blob/develop/.eslintrc#L105-L110 I set it up to use arrow-function. The only place I found where the other function style is convenient was with export default function Name() {} where the default export does not require an extra line (at the end of the file). But for typescript the arrows are a lot easier (or the only way?), so I move everything to arrows in fixmy.rsv.

---

PS: I would also prefer the string-style reporting levels over the numbers, which IMO are very abstract, see https://github.com/FixMyBerlin/fixmy.rsv/blob/develop/.eslintrc#L27.

[ohrie]

Thank you again for this huge update @cafca !
I've tested it on my machine, and it's running also flawlessly.
After we've decided on https://github.com/FixMyBerlin/fixmy.frontend/pull/912/files/143fe21a799af88cf8f5f0c9bf52829ed61fd460#r784009315 I'm looking forward to merge this.

[ohrie]

@cafca Did the cypress tests work on your machine?
On CI and my machine they fail. I get this error:
cypress-io/cypress#18435

I did try the suggested solutions, but neither worked for me.

I've tried to dig deep into it with DEBUG=cypress:webpack npx cypress open but didn't found anything problematic.