Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to return false so the window does not go back to top after close #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevbook
Copy link

@kevbook kevbook commented May 7, 2012

No description provided.

@sumeetchawla
Copy link

Your return false isn't present in the code I downloaded from the site. You can also this instead of return false. $(o.closeButton).click(function(e){e.preventDefault();close_modal(modal_id)});

I read somewhere that return false should not be used to prevent hyperlink default behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants