Remove the Heroku log drain check

We're moving this check. We currently have Problem Hub problems based on the Biz Ops data for Heroku apps, e.g. https://github.com/Financial-Times/problem-hub/blob/main/problemDefinitions/HerokuApps/herokuAppCustomerProductsMissingLogDrain.yaml We may also add log drain health checks to cp-healthchecks if we decide it's an issue. Generally though apps don't change that frequently and problem hub is probably fine for this.
Financial-Times · Aug 20, 2024 · f344a33 · f344a33
1 parent 68e0b60
commit f344a33
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 151 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -11,7 +11,6 @@
     "start": "dotcom-tool-kit run:local"
   },
   "dependencies": {
-    "@dotcom-reliability-kit/errors": "^3.0.1",
     "@dotcom-reliability-kit/logger": "^3.0.3",
     "@dotcom-reliability-kit/serialize-request": "^3.0.1",
     "@financial-times/n-flags-client": "^15.0.0",

diff --git a/src/lib/health-checks.js b/src/lib/health-checks.js
@@ -7,7 +7,6 @@
 
 const logger = require('@dotcom-reliability-kit/logger');
 
-const herokuLogDrainCheck = require('./heroku-log-drain-check');
 const metricsHealthCheck = require('./metrics-healthcheck');
 const supportedNodeJsVersionCheck = require('./supported-node-js-version-check');
 
@@ -37,19 +36,6 @@ module.exports = (app, options, meta) => {
 		supportedNodeJsVersionCheck(meta.name)
 	];
 
-	if (process.env.HEROKU_APP_ID) {
-		defaultChecks.push(herokuLogDrainCheck({
-			herokuAppId: process.env.HEROKU_APP_ID
-		}));
-	} else {
-		logger.warn({
-			event: 'N_EXPRESS_APP_MISSING_HEROKU_APP_ID',
-			message: `The ${options.systemCode} app is missing a HEROKU_APP_ID env var`,
-			systemName: options.healthChecksAppName || defaultAppName,
-			systemCode: options.systemCode
-		});
-	}
-
 	/** @type {Healthcheck[]} */
 	const healthChecks = options.healthChecks.concat(defaultChecks);
 

diff --git a/src/lib/heroku-log-drain-check.js b/src/lib/heroku-log-drain-check.js
diff --git a/test/app/heroku-log-drain-check.test.js b/test/app/heroku-log-drain-check.test.js
diff --git a/typings/n-express.d.ts b/typings/n-express.d.ts
@@ -50,20 +50,6 @@ export interface ErrorRateHealthcheckOptions {
 	samplePeriod?: string;
 }
 
-export interface HerokuLogDrainHealthcheckOptions {
-	herokuAppId?: string;
-}
-
-interface NextHealthLogDrainStatus {
-	ok: boolean;
-	description: String;
-}
-
-export interface NextHealthLogDrainResponse {
-	herokuAppId: string;
-	status: NextHealthLogDrainStatus;
-}
-
 export interface AppContainer {
 	app: Express.Application;
 	meta: guessAppDetails.Options & {