Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'q' to close buffer #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow 'q' to close buffer #7

wants to merge 1 commit into from

Conversation

m42e
Copy link

@m42e m42e commented Jun 3, 2021

This will enable 'q' to close the list buffer.

Copy link
Owner

@FiXato FiXato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, even though alphanumeric characters might make it a bit trickier to later implement keyword filtering of the list.
Then again, I'm no longer actively developing/maintaining this script (I see I still have to merge in Flashcode's changes to make it python3 compatible), so I'm not sure if it's likely I'll ever implementing that filtering anyway. :)

I'll try to look at merging your PR later this week, as well as updating it for python3, and getting the update to the official weechat repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants