Enable GitHub credential logging by default for all deployments #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local deployments (webauthndev.ftsafe.com) were not sending credential logs to GitHub because
is_logging_enabled()only auto-enabled for Render and Google Cloud environments.Changes
server/server/github_client.py: Modifiedis_logging_enabled()to returnTrueby default instead of only for hosted platformsserver/server/device_logs.py: Added attestation check fields (signature_valid,root_valid,rp_id_hash_valid,aaguid_match) to theRegistrationEventdataclass and log payloadserver/server/routes/simple.py: UpdatedRegistrationEventcreation to include the attestation check valuestests/test_github_client.py: Added test coverage for the logging enabled behaviortests/test_device_logs.py: Updated tests to verify attestation check fields are included in the log payloadBehavior
Logging still requires
GITHUB_TOKENto be configured—calls fail gracefully if missing.Log Payload
Each credential log now includes the following attestation validation fields:
signature_valid- Whether the attestation signature is validroot_valid- Whether the attestation root certificate is validrp_id_hash_valid- Whether the RP ID hash matchesaaguid_match- Whether the AAGUID matches the expected valueOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.