Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1277: add JDK 22 optimizations back to FDP #1285

Merged
merged 3 commits into from
May 1, 2024

Conversation

cowtowncoder
Copy link
Member

No description provided.

@cowtowncoder
Copy link
Member Author

@pjfanning Is this what is needed or #1277 ?

@cowtowncoder
Copy link
Member Author

cowtowncoder commented Apr 30, 2024

Ok, there seems to be an issue; maybe due to Shade plugin not working with JDK 22 bytecode.
There's a newer version; need to update version via oss-parent now.

@cowtowncoder
Copy link
Member Author

Ok so either Shade plugin, or latest Maven, fixed the problem: CI passes now.

Copy link
Member

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@cowtowncoder cowtowncoder merged commit 7d8dc09 into 2.18 May 1, 2024
5 of 6 checks passed
@cowtowncoder cowtowncoder deleted the tatu/2.18/1277-reenable-java22-for-fdp branch May 1, 2024 03:23
cowtowncoder added a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants