Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isKeyboardInternallyHandled to allow custom logic again #2541

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ImBeCiliC
Copy link

No description provided.

@ImBeCiliC
Copy link
Author

@kesha-antonov this should resolve these issues + adding back the functionality of having a custom keyboard handler
Fixes:
#2523
#2504

@JoniVR
Copy link

JoniVR commented Oct 21, 2024

I agree that this option should be present, however, this current implementation doesn't remove the functionality entirely. The useAnimatedKeyboard reanimated hook also manipulates default adjustResize behavior. The hook is not unmounted in this implementation, so I assume this manipulation will remain present. See: https://docs.swmansion.com/react-native-reanimated/docs/device/useAnimatedKeyboard/#remarks

So ideally, the keyboard implementation gets implemented and lazily imported into the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants