WIP feat: support Kafka messages with nullable or empty partition key #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergioamribeiro
requested review from
carlosgoias,
martinhonovais,
Daniel-C-Dias,
luispfgarces,
jorgedgodinho,
spookylsm,
rodrigobelo,
fernando-a-marins and
brunohfgomes
sergioamribeiro
force-pushed
the
us/support-nullable-partition-key
branch
from
0525ef7 to
7f1e964
Compare
brunohfgomes
previously approved these changes
May 12, 2022
carlosgoias
previously approved these changes
May 19, 2022
Daniel-C-Dias
previously approved these changes
May 20, 2022
fernando-a-marins
suggested changes
May 27, 2022
...ests/Core/Storages/Assertion/RetryDurableGuaranteeOrderedConsumptionPhysicalStorageAssert.cs
Show resolved
Hide resolved
...tegrationTests/Core/Storages/Assertion/RetryDurableLatestConsumptionPhysicalStorageAssert.cs
Show resolved
Hide resolved
src/KafkaFlow.Retry/Durable/Repository/RetryDurableQueueRepository.cs
Outdated
Show resolved
Hide resolved
src/KafkaFlow.Retry/Durable/Repository/RetryDurableQueueRepository.cs
Outdated
Show resolved
Hide resolved
| using Xunit; | ||
|
|
||
| [Collection("BootstrapperHostCollection")] | ||
| public class EmptyPartitionKeyRetryDurableTests |
There was a problem hiding this comment.
It's missing tests with the null partition key. But please check my other comment.
There was a problem hiding this comment.
we can't test with a null partition because the Kafka flow doesn't support it.
There was a problem hiding this comment.
You can test it if the test does not start with the production of a Kafka message but with a consumption. If we want to support null partition keys we should have a test for it.
spookylsm
dismissed stale reviews from Daniel-C-Dias, carlosgoias, and brunohfgomes
via
abbcaca
…xtensions into us/support-nullable-partition-key
…xtensions into us/support-nullable-partition-key
carlosgoias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request adds protection for the kafka messages that arrive without a value for the partition key (null or empty). The Retry will receive the messages and put them in the same queue and follow that order to process
Fixes # (10)
How Has This Been Tested?
We've made some unit and integration tests (see
EmptyPartitionKeyRetryDurableTestsclass)Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement