Added radius rescaling to simple env #1213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements dynamic rescaling of the entity radius as we 'Zoom In' or 'Zoom out' of the rendering. This fixes #1188 which mentions that keeping the radius constant when rescaling the coordinates leads to an illusion of fixed obstacles coming closer or moving away from each other when in reality they are fixed.
Files modified: simple_env.py
High-level overview: Extended the concept of cam_range and recorded the original cam_range to scale the radius
Fixes #1188 , Depends on None
Type of change
Screenshots
Notice how the zoom out effect is more intuitive in the dynamic resizing case
Before dynamic resizing:
After dynamic resizing:
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no new errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.