-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow AssertOutOfBoundsWrapper to be applied to any environment #1046
Allow AssertOutOfBoundsWrapper to be applied to any environment #1046
Conversation
It turns out that all the spaces have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elliottower why can this wrapper not be made general such that it works with all spaces?
Yea that’s the plan, jet and I discussed a bit in the discord if you
didn’t see
…On Tue, Jul 25, 2023 at 5:29 PM Mark Towers ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@elliottower <https://github.com/elliottower> why can this wrapper not be
made general such that it works with all spaces?
—
Reply to this email directly, view it on GitHub
<#1046 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHVPVA57I5HXM2TTDPK6BITXSA3CZANCNFSM6AAAAAA2XNFI3I>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@pseudo-rnd-thoughts I removed the check for Discrete environments and changed the unwrapped tests so that the wrapper gets tested on all space types, can you rereview? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks good to me
Description
Allows
AssertOutOfBoundsWrapper
to be applied to environments with any action space type, resolving #866.Type of change
Screenshots
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.