Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtraj #140

Closed
wants to merge 2 commits into from
Closed

Subtraj #140

wants to merge 2 commits into from

Conversation

jsw7460
Copy link

@jsw7460 jsw7460 commented Sep 7, 2023

Description

Include a sub-trajectory sampling and refer to the example code provided in the documents.
The code is quite straightforward.

This is my first time for pull-requesting. If there are additional requirements or concerns, please inform me.
Additionally, I persistently encountered errors in sections unrelated to my code when attempting to run the code for Checklist 1, so I did not check it.

Fixes #134

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@younik
Copy link
Member

younik commented Jan 27, 2024

Closing for inactivity

@younik younik closed this Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants