mujoco_py_env: Only raise an exception if MuJocoPyEnv class is actually used #1060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before #934 just running
from gymnasium.envs.mujoco import MuJocoPyEnv
did not resulted in aerror.DependencyNotInstalled
exception, but the expection was only raised whenMuJocoPyEnv.__init__
constructor was called.Instead after #934 just calling
from gymnasium.envs.mujoco.mujoco_py_env import MuJocoPyEnv
results in aerror.DependencyNotInstalled
exception, that I guess create an hard error during test collection.This result in an hard error when collecting tests in conda-forge/gymnasium-feedstock#36, where
mujoco_py
is not available. Note that there is a similar change in #934 related tomujoco
module itself, but that is less problematic as it a maintained library, differently frommujoco_py
.Type of change
Please delete options that are not relevant.
Screenshots
Not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)