-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tvdb indexer #899
base: develop
Are you sure you want to change the base?
Conversation
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Any update on this feature? 👀 I think this would help with the issue described here #648 |
Sorry, I've got a lot of work at the moment but I've continued to work on it, I'm trying to use directly the api that sonarr uses, skyhook. |
Looks like half of the tests are failing. Could you take a look and try to fix them? And add some for TVDB? |
Hello, indeed, I solved the problem of the existing tests and I added tests for tvdb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go into detail, but the overall looks good.
I'll make a more in-depth review later.
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
This can be tested with the |
@TOomaAh next time you should rebase instead of merge. Merging makes the history look messy. It's also in our contributing guide to rebase instead of merging |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
2ee5535
to
f447870
Compare
Description
Screenshot (if UI-related)
To-Dos
pnpm build
pnpm i18n:extract
Issues Fixed or Closed