Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: queue pageSize to get more than 10 downloading items in Servarr #1055

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Mavyre
Copy link

@Mavyre Mavyre commented Oct 28, 2024

Allows to get all processing Series when entire seasons are downloded on Sonarr

Description

When downloading Season packs, Jellyseerr wasn't displaying all the downloading episodes due to Servarr default pageSize set to 10. 1000 should be a safe number to display correctly the processing items while downloading multiple Seasons (or season with >10 episodes) in parallel.

Screenshot (if UI-related)

Not UI related

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

None

…r/Radarr

Allows to get all processing Series when entire seasons are downloded on Sonarr
@Mavyre Mavyre changed the title Updated queue pageSize to get more than 10 downloading items in Servarr fix: queue pageSize to get more than 10 downloading items in Servarr Oct 28, 2024
Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typing issue

Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are still failing.
Looks like prettier hasn't been executed: pnpm run format

Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just spoken to Fallenbagel about it, and we think this should be a setting. As he said:

Requesting excessive data from a slow CPU or a system that may experience I/O bottlenecks could cause performance degradation

meaning that it can potentially cause problems if hundreds of downloads are in progress (retrieved from a seedbox, for example).

Could you please refactor this so it's an option in the Radarr/Sonarr settings?

@Mavyre
Copy link
Author

Mavyre commented Nov 13, 2024

I've just spoken to Fallenbagel about it, and we think this should be a setting. As he said:

Requesting excessive data from a slow CPU or a system that may experience I/O bottlenecks could cause performance degradation

meaning that it can potentially cause problems if hundreds of downloads are in progress (retrieved from a seedbox, for example).

Could you please refactor this so it's an option in the Radarr/Sonarr settings?

Sure, but I'd have to check out Jellyseerr code a litttle bit more than just adding easily this option, to get things done properly. I'll need a more few weeks to have time to get into it.

Any help appreciated :)

@gauthier-th
Copy link
Collaborator

I've just spoken to Fallenbagel about it, and we think this should be a setting. As he said:

Requesting excessive data from a slow CPU or a system that may experience I/O bottlenecks could cause performance degradation

meaning that it can potentially cause problems if hundreds of downloads are in progress (retrieved from a seedbox, for example).
Could you please refactor this so it's an option in the Radarr/Sonarr settings?

Sure, but I'd have to check out Jellyseerr code a litttle bit more than just adding easily this option, to get things done properly. I'll need a more few weeks to have time to get into it.

Any help appreciated :)

You'd want to add a number in the DVRSetting interface, then you can go in src/components/Settings/RadarrModal.tsx and src/components/Settings/SonarrModal.tsx to add the setting, and then get the pageSize setting from the place getQueue is called and pass it to the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants