Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 'Request New Seasons' option added to request dialog #1167

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

FlamingKeyboard
Copy link

@FlamingKeyboard FlamingKeyboard commented Dec 20, 2024

Description

Feature to allow end users to specify if they want to monitor new releases in Sonarr or just monitor currently released seasons.

This is my first public PR, so my sincere apologies if I missed the mark on anything, I tried to follow the contributing guidelines as closely as I could. I'm not confident in my database migration, so if the reviewer reading this could exercise extra scrutiny when reviewing that portion, that would be sincerely appreciated.

Screenshot (if UI-related)

image

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in the server/migration/sqlite folder.

And you should generate the PostgreSQL migration too. I'll write some documentation on how to generate properly these migrations this week-end.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason to have changes in this file.

server/api/servarr/sonarr.ts Show resolved Hide resolved
Comment on lines +37 to +39
searchAutomatically: 'Search Automatically',
searchAutomaticallyDescription:
'Automatically search for this movie in Radarr after the request is approved.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useless for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] add 'Search Automatically' and 'Request New Seasons' options to request dialog
3 participants