Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] add 'Search Automatically' and 'Request New Seasons' options to request dialog #1047

Open
1 task
ftc2 opened this issue Oct 23, 2024 · 5 comments · May be fixed by #1167
Open
1 task

[FR] add 'Search Automatically' and 'Request New Seasons' options to request dialog #1047

ftc2 opened this issue Oct 23, 2024 · 5 comments · May be fixed by #1167
Labels
awaiting triage This issue needs to be reviewed enhancement New feature or request

Comments

@ftc2
Copy link

ftc2 commented Oct 23, 2024

Description

example use cases for exposing these options on the request dialog:

Search Automatically:

  • for a sonarr/radarr instance configured in jellyseerr with Enable Automatic Search enabled, an admin with access to sonarr/radarr may occasionally prefer to manually select a release instead of relying on the selected quality profile. this saves the trouble of removing a potentially unwanted release from the download client.

Request New Seasons:

  • a conscientious user may elect to not automatically request new seasons for a series.
  • on reviewing a pending request, an admin may decide to not automatically request new seasons for a series.

Desired Behavior

dialog mockup:

jellyseerr-request-mockup

implementation suggestions:

Search Automatically (movies and series):

  • default value: equivalent to the value of Enable Automatic Search for that instance (Jellyseerr > Settings > Services)
  • visibility: require Advanced Requests permission. part of the advanced request dialog because it's likely only useful to admins with access to sonarr/radarr

Request New Seasons (series):

  • default value: true
  • visibility: require Request permission
  • this should essentially change the value of Monitor New Seasons for that series in sonarr (sonarr > individual series page > Edit > Monitor New Seasons)

Additional Context

No response

Code of Conduct

  • I agree to follow Jellyseerr's Code of Conduct
@ftc2 ftc2 added awaiting triage This issue needs to be reviewed enhancement New feature or request labels Oct 23, 2024
FlamingKeyboard pushed a commit to FlamingKeyboard/jellyseerr that referenced this issue Dec 20, 2024
@FlamingKeyboard
Copy link

FlamingKeyboard commented Dec 20, 2024

image
I really wanted this feature, so I worked on it and believe I have it working, will submit my PR.

@ftc2
Copy link
Author

ftc2 commented Dec 20, 2024

@FlamingKeyboard amazing

@ftc2
Copy link
Author

ftc2 commented Dec 20, 2024

thanks a lot!

just fyi, there is a bug in sonarr with the 'monitor new seasons' feature. if it is set to false for a series that has a monitored, currently-airing season, a bug happens when new episodes for that season come in from tvdb. such episodes will end up as unmonitored. details here:
Sonarr/Sonarr#7401

i don't think the fix has made it over from the develop branch yet. i checked, and for sure it is not in 4.0.11.2680

so exercise some caution when using that feature in sonarr. if you are monitoring a current season for a series, be sure all the episodes have metadata (season finale episode is known about in sonarr) before you set 'monitor new seasons' to false for that series.

@FlamingKeyboard
Copy link

FlamingKeyboard commented Dec 20, 2024

thanks a lot!

just fyi, there is a bug in sonarr with the 'monitor new seasons' feature. if it is set to false for a series that has a monitored, currently-airing season, a bug happens when new episodes for that season come in from tvdb. such episodes will end up as unmonitored. details here: Sonarr/Sonarr#7401

i don't think the fix has made it over from the develop branch yet. i checked, and for sure it is not in 4.0.11.2680

so exercise some caution when using that feature in sonarr. if you are monitoring a current season for a series, be sure all the episodes have metadata (season finale episode is known about in sonarr) before you set 'monitor new seasons' to false for that series.

Ah yikes, that's a basket of worms. Thanks for the heads up, I have to step away from my dev box for some holiday travel, but if it's still an issue after new years I can look into implementing that check. Tests on my personal setup appear to run flawlessly, but I don't think I've hit that specific case yet.

Thanks for requesting this and providing the mockup; great idea. I didn't include the "Search Automatically" functionality requested, but when/if the previous feature gets merged I can take a crack at it.

@ftc2
Copy link
Author

ftc2 commented Dec 20, 2024

imo no need to implement a workaround for the sonarr bug. i'm personally fine with just being careful until the fix trickles down to me. besides, the workaround would need to be removed later when the bug gets fixed.

also, even if you don't add the autosearch checkbox, your PR should give me a solid head start on doing it myself eventually. :)

@gauthier-th gauthier-th linked a pull request Dec 20, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage This issue needs to be reviewed enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants