Modernize tools #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
force-pushed
the
modernize-tools
branch
from
81b3e08
to
51e0733
Compare
thomaslevesque
commented
Feb 3, 2022
There was a problem hiding this comment.
In PrepareRelease, since we can't have extension methods in a file with top-level statements, I put them in a separate class.
But then it was ugly to have them access the repo name as a static field, so I refactored the class into a wrapper around GitHubClient.
If you preferred it as it was before, we don't have to use top-level statements, I can just revert the changes.
blairconrad
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Thanks, @thomaslevesque. I'm happy with everything. A little confused about one comment, but if you're good, I'll merge.
blairconrad
approved these changes
Feb 4, 2022
|
Thanks, @thomaslevesque! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use top-level statements in programs
Use implicit usings
Refactor GitHubClient extension methods into GitHubClient wrapper class
Remove a redundant PackageReference Remove element