Skip to content

Fixed packager insertion deleting items #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: mc1.20.1/fabric/dev
Choose a base branch
from
Open

Fixed packager insertion deleting items #1799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/com/simibubi/create/content/logistics/packager/PackagerBlockEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,16 +374,19 @@ public boolean unwrapBox(ItemStack box, TransactionContext ctx) {
// note: handler may modify the passed items
boolean unpacked = toUse.unpack(level, target, targetState, facing, items, orderContext, ctx);

// Only proceed if unpacking was successful (all items were placed)
if (unpacked) {
TransactionCallback.onSuccess(ctx, () -> {
previouslyUnwrapped = box;
animationInward = true;
animationTicks = CYCLE;
notifyUpdate();
});
return true;
} else {
// Unpacking failed, return false to prevent the package from being consumed
return false;
}

return true;
}

public void attemptToSend(List<PackagingRequest> queuedRequests) {
Expand Down