Split large RecipeBookAddS2CPacket's in a vanilla client compatible way. #4590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
added
enhancement
modmuss50
commented
Apr 20, 2025
| packetSender.accept(new RecipeBookAddS2CPacket(collectedEntries, shouldReplace)); | ||
|
|
||
| collectedEntries = new ArrayList<>(); | ||
| byteBuf = new RegistryByteBuf(PacketByteBufs.create(), networkHandler.getPlayer().getRegistryManager()); |
There was a problem hiding this comment.
Can we reuse the old byte buf? Or maybe even use this one as the packet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a pack with a large amount of recipes the RecipeBookAddS2CPacket can exceed the packet size limit. This PR splits the single RecipeBookAddS2CPacket into multiple packets when needed. This is compatible with vanilla clients as they can accept multiple packets.