-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat unexpanded Gradle version property as satisfied dependency #457
base: master
Are you sure you want to change the base?
Conversation
Another solution would be to set the gradle version from the mod json. |
Do you mean loading the version from |
The main problem is that people can use any custom token for substitution; nothing prevents them from using |
Gradle has a json parser - you can simply read the file and set the version. |
This was also previously discussed in #359 |
The best solution would be to make the generated minecraft run configuration run the |
Ah that sounds even better. I'll make a PR for the example mod. |
See FabricMC/fabric-loader#457 Signed-off-by: liach <[email protected]>
Fyi I sent a pr, and that works good per my testing |
I think I want to do do two things here:
This way the default just works and the classic approach is fixable as well. I don't like the special casing used in this PR, implementing the option 2 from above should wait until my next big PR is in. |
We now have various simple approaches:
|
This helps when testing mod compatibility with mods that have a dependency on the mod that is being developed.