Add missing recursive calls when anonymizing unions #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Yeah but there's a helper called visit_expr_w that does this for you automatically (while also calling the visitor on the type itself). Other than that looks great I remember hitting this bug years ago and working around it by not using -fanonymous-unions |
Member
Author
|
Nice, thanks! Updated. |
msprotz
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into this bug today (see testcase). I think this is the fix, the one thing I'm not sure about is whether passing
t2.typis correct. It seems like it's meant to be the type of the expression being visited, but I don't understand OCaml visitors well enough to be sure.