Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slug to speakers xml export (proposal) #266

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

johanvdw
Copy link
Member

@johanvdw johanvdw commented Nov 24, 2024

Adds the slug of speakers to the xml export. Can be used to fetch user information on the website for apps.
Example file for 2024:
schedule.xml.zip

speakers can be reached by this slug:
https://fosdem.org//schedule/speaker/

This is just a proposal, we might as well add all speaker information inside the xml as well under a new section. Not sure what would be most appropriate.

@loomchild
Copy link

loomchild commented Nov 25, 2024

IMO adding the speaker info directly in schedule.xml (bio and picture to be precise, slug can be there as well) would be better, since then, we can display natively in the apps without embedding the page or scraping it.

@@ -68,7 +68,7 @@ xml.schedule do
xml.feedback_url event[:feedback_url]
xml.persons do
event[:speakers].map(&$to_speaker).each do |speaker|
xml.person( speaker[:name], {:id=>speaker[:person_id]} )
xml.person( speaker[:name], {:id=>speaker[:person_id],:slug=>speaker[:slug]} )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add:

:avatar=>speaker[:avatar],:biography=>speaker[:biography]

(only based on documentation, I haven't tested it, can do it later this week)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that is the right solution, because it would duplicate biographies for speakers. Moreover, I would not store the biography as an attribute.

Perhaps we could add a section. xxxyyyy, so both can be linked?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are right, although I am not sure how big of a problem duplicates are. Probably the change would need to be backwards-compatible, so speaker name can stay and a new section by person_id or code (I can look into this on the weekend).

@loomchild
Copy link

loomchild commented Nov 25, 2024

Wait, is Pretalx is using Ruby - oh cool, perhaps I can even help to improve the PR:)

@johanvdw
Copy link
Member Author

Wait, is Pretalx is using Ruby - oh cool, perhaps I can even help to improve the PR:)

No the website is using Ruby, pretalx is written in Python.

But hey, we can use hands on the website as well, perhaps even more.

@loomchild
Copy link

I have published an alternative solution with the whole section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants