-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slug to speakers xml export (proposal) #266
base: master
Are you sure you want to change the base?
Conversation
IMO adding the speaker info directly in |
@@ -68,7 +68,7 @@ xml.schedule do | |||
xml.feedback_url event[:feedback_url] | |||
xml.persons do | |||
event[:speakers].map(&$to_speaker).each do |speaker| | |||
xml.person( speaker[:name], {:id=>speaker[:person_id]} ) | |||
xml.person( speaker[:name], {:id=>speaker[:person_id],:slug=>speaker[:slug]} ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add:
:avatar=>speaker[:avatar],:biography=>speaker[:biography]
(only based on documentation, I haven't tested it, can do it later this week)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that is the right solution, because it would duplicate biographies for speakers. Moreover, I would not store the biography as an attribute.
Perhaps we could add a section. xxxyyyy, so both can be linked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you are right, although I am not sure how big of a problem duplicates are. Probably the change would need to be backwards-compatible, so speaker name can stay and a new section by person_id
or code
(I can look into this on the weekend).
Wait, is Pretalx is using Ruby - oh cool, perhaps I can even help to improve the PR:) |
No the website is using Ruby, pretalx is written in Python. But hey, we can use hands on the website as well, perhaps even more. |
I have published an alternative solution with the whole section. |
Adds the slug of speakers to the xml export. Can be used to fetch user information on the website for apps.
Example file for 2024:
schedule.xml.zip
speakers can be reached by this slug:
https://fosdem.org//schedule/speaker/
This is just a proposal, we might as well add all speaker information inside the xml as well under a new section. Not sure what would be most appropriate.