Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML updates #263

Merged
merged 29 commits into from
Nov 17, 2024
Merged

HTML updates #263

merged 29 commits into from
Nov 17, 2024

Conversation

edent
Copy link
Contributor

@edent edent commented Nov 15, 2024

This PR:

  • Fixes most broken HTML
  • Adds some semantic HTML (more to come if this is accepted)
  • Makes phone numbers clickable
  • Better support for mobile devices (front page still needs work)
  • Corrects broken links
  • Minor CSS improvements (more to come)
  • Spelling corrections
  • Alt text fixes
  • Removes link to Twitter (hasn't been updated in years)

I've run nanoc and all the files compile and pass validation (nanoc likes putting stray /> at the end of some elements - but that doesn't break anything).

Visually, most pages stay the same. A few minor tweeks to allow pages to work on narrow screens.

Happy to make any changes.

Addresses #261

Copy link
Member

@kragniz kragniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -38,20 +38,20 @@ <h3>Get in touch</h3>

<p>
During the event, the Infodesk is reachable by phone using the number
<span class="tel">+32 2 7887474</span> (for <u><b>urgent</b></u> matters only, please).
<a class="tel" hef="tel:+3227887474">+32 2 788 74 74</a> (for <u><strong>urgent</strong></u> matters only, please).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be:

Suggested change
<a class="tel" hef="tel:+3227887474">+32 2 788 74 74</a> (for <u><strong>urgent</strong></u> matters only, please).
<a class="tel" href="tel:+3227887474">+32 2 788 74 74</a> (for <u><strong>urgent</strong></u> matters only, please).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this up in 01390cd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh! Cheers 😁

@@ -22,7 +22,7 @@
<ul class="unstyled" id="all-news">
<% @item[:newsitems].map(&$to_item).each do |item| %>
<li class="news-item">
<span class="date"><a href="<%= item.path %>"><%= item[:created_at].strftime '%Y-%m-%d' %></a><span class="date-separator">&nbsp;&#x00BB;&nbsp;</span></span>
<time class="date"><a href="<%= item.path %>"><%= item[:created_at].strftime '%Y-%m-%d' %></a></time>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the link actually get shown on mobile devices (which is a big improvement), but makes it slightly less visible otherwise:

new:
Screenshot from 2024-11-17 17-23-55

previous:
Screenshot from 2024-11-17 17-24-07

@kragniz kragniz merged commit 8ae6f94 into FOSDEM:master Nov 17, 2024
1 check passed
@johanvdw
Copy link
Member

johanvdw commented Nov 17, 2024

  • Removes link to Twitter (hasn't been updated in years)

What makes you think so? there are several items posted this month:
https://x.com/fosdem

I don't think we should remove it as part of a styling update (which, to be clear is very much appreciated).

@edent
Copy link
Contributor Author

edent commented Nov 17, 2024

When I visited it, I couldn't see any posts newer than 2021. But, if it is still in use, let me know and I'll restore the link.

Here's what I see
Screenshot showing old posts

@edent
Copy link
Contributor Author

edent commented Nov 20, 2024

  • Removes link to Twitter (hasn't been updated in years)

What makes you think so? there are several items posted this month: https://x.com/fosdem

I've just seen that Twitter serves up stale content if you're not logged in! My mistake entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants