-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML updates #263
HTML updates #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -38,20 +38,20 @@ <h3>Get in touch</h3> | |||
|
|||
<p> | |||
During the event, the Infodesk is reachable by phone using the number | |||
<span class="tel">+32 2 7887474</span> (for <u><b>urgent</b></u> matters only, please). | |||
<a class="tel" hef="tel:+3227887474">+32 2 788 74 74</a> (for <u><strong>urgent</strong></u> matters only, please). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
<a class="tel" hef="tel:+3227887474">+32 2 788 74 74</a> (for <u><strong>urgent</strong></u> matters only, please). | |
<a class="tel" href="tel:+3227887474">+32 2 788 74 74</a> (for <u><strong>urgent</strong></u> matters only, please). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this up in 01390cd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh! Cheers 😁
@@ -22,7 +22,7 @@ | |||
<ul class="unstyled" id="all-news"> | |||
<% @item[:newsitems].map(&$to_item).each do |item| %> | |||
<li class="news-item"> | |||
<span class="date"><a href="<%= item.path %>"><%= item[:created_at].strftime '%Y-%m-%d' %></a><span class="date-separator"> » </span></span> | |||
<time class="date"><a href="<%= item.path %>"><%= item[:created_at].strftime '%Y-%m-%d' %></a></time> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes you think so? there are several items posted this month: I don't think we should remove it as part of a styling update (which, to be clear is very much appreciated). |
I've just seen that Twitter serves up stale content if you're not logged in! My mistake entirely. |
This PR:
I've run nanoc and all the files compile and pass validation (nanoc likes putting stray
/>
at the end of some elements - but that doesn't break anything).Visually, most pages stay the same. A few minor tweeks to allow pages to work on narrow screens.
Happy to make any changes.
Addresses #261