Add CI for volunteers page #42
Conversation
|
Thanks a lot - sorry for only seeing this now (as we run fosdem only once a year, I don't check the repo very often.). I'll review. |
|
Sure, no problem! |
ci/Dockerfile
Outdated
| @@ -0,0 +1,8 @@ | |||
| FROM python:3.7-buster | |||
There was a problem hiding this comment.
I just bumped the server to bullseye, we probably should base our ci on that as well.
requirements-frozen.txt
Outdated
| @@ -1,4 +1,6 @@ | |||
| arabic-reshaper==2.1.1 | |||
| astroid==2.5.6 | |||
There was a problem hiding this comment.
perhaps it would be better to create a requirements-dev file which includes dependencies for development, and not for deploy.
There was a problem hiding this comment.
I split the two apart, which also removed the merge conflict. That should suffice for now. In the long run, poetry may be an option, but one step at a time. :)
|
|
||
| jobs: | ||
| test_job: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
It should not make a big difference, but we tend to use debian rather than ubuntu.
There was a problem hiding this comment.
I get "Can't find any online and idle self-hosted runner in the current repository, account/organization that matches the required labels: 'debian-latest'" when I try that.
It seems like GitHub has decided to stick with Ubuntu for all of their Linux CI hosts: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners
So, unfortunately, we will be limited to the Docker container for Debian.
There was a problem hiding this comment.
SourceHut offers Debian VM images and I'd be glad to integrate it with this repo if it is desired.
There was a problem hiding this comment.
The os doesn't really matter as we are using a virtualenv anyway. But thanks for the suggestion anyway.
There was a problem hiding this comment.
Doing it would require either trusting me for owner privilege or creating a paying account for FOSDEM ($20/year; builds.sr.ht got hit by cryptocurrency miners and decided to require payment earlier than initially planned). Personally I'm OK with either but it's up for the maintainers to decide if it's worth it.
| set -o errexit | ||
| set -o nounset | ||
|
|
||
| sed "\ |
There was a problem hiding this comment.
Rather than using sed, I would provide a specific settings_sqlite.py and a settings_postgres.py . I'm okay doing this now, but in any case, I think we can improve how this is done:
#44
This change includes the first automated test for the system.
|
I squashed all my changes to make merging and future review easier. |
Leveraging free (as in beer) resources for open-source CI, we can start improving the software quality of the volunteers portal and thereby make changes easier and bugs rarer going forward.
If you all agree that codecov is a good idea, I will need to add the upstream project there before merging.