This repository was archived by the owner on Jun 17, 2021. It is now read-only.
Fix freeze upon opening Credits tab#32
Open
recreationx wants to merge 2 commits intoFICTURE7:v0.1.xfrom
Open
Conversation
FICTURE7
reviewed
May 4, 2019
| throw new NotImplementedException(); | ||
| using (var bytes = new MemoryStream(data)) | ||
| { | ||
| var channel = EnumProxy<ChannelType>.Deserialize(bytes); |
FICTURE7
suggested changes
May 4, 2019
FICTURE7
reviewed
May 7, 2019
| } | ||
| using (var outBytes = new MemoryStream()) | ||
| { | ||
| EnumProxy<ChannelType>.Serialize(outBytes, channel); |
Owner
There was a problem hiding this comment.
The base class should not contain any hardcoded logic, instead rely on the abstract method's implementation.
Suggested change
| EnumProxy<ChannelType>.Serialize(outBytes, channel); | |
| List<BundleView> bundles = OnGetBundles(channel); | |
| ListProxy<BundleView>.Serialize(outBytes, bundles, BundleView.Serialize) |
Contributor
Author
There was a problem hiding this comment.
BundleView does not contain definition for Serialize
Owner
There was a problem hiding this comment.
Oops, apologies that should be BundleViewProxy.Serialize
FICTURE7
suggested changes
May 7, 2019
Owner
FICTURE7
left a comment
FICTURE7
left a comment
There was a problem hiding this comment.
Looks good to me other than the hardcoded logic.
FICTURE7
reviewed
May 7, 2019
|
|
||
| private readonly UberStrikeItemShopClientView _items; | ||
| private readonly WebServiceContext _ctx; | ||
| private readonly List<BundleView> _bundles; |
Owner
There was a problem hiding this comment.
This is not initialized, should be an empty list
Suggested change
| private readonly List<BundleView> _bundles; | |
| _bundles = new List<BundleView>(); |
Owner
There was a problem hiding this comment.
Do that somewhere in the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it so GetBundles returns something so it does not freeze the client when opening "Credits" tab in Shop