LibraryForwarding: Redo Vulkan definitions update #5210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb95a95 (FEX-Emu#5171) did not keep the interface file in sync with the output of DefinitionExtract.py. Some definitions were reordered in the Vulkan headers. There also is no "conflict" about CUDA extensions; instead, the previous update didn't reflect that the new headers fully hide beta extensions.
Member
Author
|
CC @lioncash : To note for future reviews of Vulkan header updates: DefinitionExtract output must be reproducible, and breaking it makes future updates needlessly involved. |
neobrain
force-pushed
the
fix_libfwd_vulkan_update
branch
from
b8d448e to
a26aee4
Compare
Sonicadvance1
approved these changes
Jan 9, 2026
Member
Sonicadvance1
left a comment
Sonicadvance1
left a comment
There was a problem hiding this comment.
I'll give this a test today.
Member
Author
|
Thanks for testing! FYI git-diff supports highlighting moved lines with a separate color, using which it becomes apparent that the first two patches here are NFC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eb95a95 (#5171) did not keep the interface file in sync with the output of DefinitionExtract.py. Some definitions were reordered in the Vulkan headers, and diverging from that order makes future Vulkan header updates harder to diff and integrate.
There also is no "conflict" about CUDA extensions; instead, the previous update didn't reflect that the new headers fully hide beta extensions. (See also #5208)
Also refreshed the definitions used for 32-bit applications.