Accurate stack mapping, fixes #5149 #5187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svc64
force-pushed
the
accurate-stack-mapping
branch
from
43ceea0 to
d10fc5c
Compare
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Jan 3, 2026
This enables clang for the cross-compile toolchains. We forgot to pass this value through for FEXLinuxTests. Necessary to get FEX-Emu#5187 passing.
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Jan 3, 2026
This enables clang for the cross-compile toolchains. We forgot to pass this value through for FEXLinuxTests. Necessary to get FEX-Emu#5187 passing.
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Jan 3, 2026
Necessary to get FEX-Emu#5187 passing.
Member
|
Theoretically now that #5191 is merged, once you rebase this it should start passing CI. |
svc64
force-pushed
the
accurate-stack-mapping
branch
3 times, most recently
from
327ccfb to
d2a2506
Compare
Contributor
Author
|
Anyways CI is passing now... I didn't test behavior on kernels older than 5.8, I don't have such machine. |
Behavior should now match the matrix in FEX-Emu#5149
svc64
force-pushed
the
accurate-stack-mapping
branch
from
d2a2506 to
92e71b2
Compare
Sonicadvance1
approved these changes
Jan 9, 2026
Member
|
Thanks for fixing this weird edge case behaviour! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added unit tests for different
PT_GNU_STACKpermissions.This is my first PR so hopefully code conventions and such are fine.