FEXCore: Move InternalThreadState StartRunning to frontend #4182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
force-pushed
the
move_start_paused
branch
2 times, most recently
from
76042f1 to
58bfeb4
Compare
We were using this variable for two things, letting the frontend signal to the backend that it wants to start executing once the thread is created, and also for handling thread pausing. These two features are conflated with one another and actually makes things more confusing. - Move StartRunning/StartPaused to the frontend, because its a construct that only needs to exist in the frontend - Adds a FEX::HLE::ThreadStateObject CV for handling pausing, which only needs to exist for gdbserver
Now that most of the thread tracking is in the frontend, change this over to building the thread execution handler on the parent thread. Removes a memory allocation/free pair, and removes the copy of each variable in the child thread.
Sonicadvance1
force-pushed
the
move_start_paused
branch
from
e1a8199 to
e771e25
Compare
lioncash
approved these changes
Nov 29, 2024
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Nov 29, 2024
Relies on FEX-Emu#4182 and FEX-Emu#4183 getting merged first, which is the first three commits. These are all frontend constructs with mostly deprecated constraints. WaitingToStart isn't used anymore, Running is effectively always true (and behaviour has changed that if a thread is alive, it's running). The only one that remains is `ThreadSleeping` which is only handled in the frontend, and there was some conflation between ThreadSleeping and Running which was hard to gauge. So delete `Running` and `WaitingToStart`, but move `ThreadSleeping` to the frontend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using this variable for two things, letting the frontend signal
to the backend that it wants to start executing once the thread is
created, and also for handling thread pausing. These two features are
conflated with one another and actually makes things more confusing.
that only needs to exist in the frontend
needs to exist for gdbserver