FEXCore: Moves TLS initialization for Alloc::OSAllocator #4174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Nov 28, 2024
Relies on FEX-Emu#4174 first to move TLS setup to the frontend. Only in one location does the frontend actually care about this, the backend doesn't care at all.
Alloc::OSAllocator uses a TLS variable of the thread object so it can use a forkable mutex plus a deferring signal section. This was setup when the FEXCore "ExecutionThread" function is called, which is a bit awkward and is an artifact from when the thread creation was mixed between the frontend and the backend. Instead let the frontend inform the backend when to install the TLS variable. This is one step required to make GdbServer work correctly again since the thread initialization and pausing is awkward today.
Sonicadvance1
force-pushed
the
gdbserver_move_alloc_tls
branch
from
cb38c8d to
3ecc66f
Compare
lioncash
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alloc::OSAllocator uses a TLS variable of the thread object so it can use a forkable mutex plus a deferring signal section. This was setup when the FEXCore "ExecutionThread" function is called, which is a bit awkward and is an artifact from when the thread creation was mixed between the frontend and the backend.
Instead let the frontend inform the backend when to install the TLS variable.
This is one step required to make GdbServer work correctly again since the thread initialization and pausing is awkward today.