Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop loading the same project multiple times 294 #295

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ryantm
Copy link
Contributor

@ryantm ryantm commented Jan 7, 2025

Why

What changed

  • Make a copy of the FileNames and loop over that instead, so when loadExtendProject adds to the FileNames, it doesn't try to load it again

Test plan

  • The repro in issue 294 now passes

@ryantm ryantm changed the title fix: stop Load from being reentrant 294 fix: stop from loading the same project multiple times 294 Jan 7, 2025
@ryantm ryantm changed the title fix: stop from loading the same project multiple times 294 fix: stop loading the same project multiple times 294 Jan 7, 2025
Why
===
* F1bonacc1#294

What changed
===
* Make a copy of the FileNames and loop over that instead, so when
loadExtendProject adds to the FileNames, it doesn't try to load it
again

Test plan
===
* The repro in issue 294 now passes
@ryantm ryantm force-pushed the rtm-01-06-fix-extends branch from 5881344 to 21996d6 Compare January 7, 2025 05:07
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link
Owner

@F1bonacc1 F1bonacc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
Thanks Ryan.

@F1bonacc1 F1bonacc1 merged commit 9d9e730 into F1bonacc1:main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants