Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for processes to start when condition: process_started #148

Merged

Conversation

anmonteiro
Copy link
Contributor

I noticed that, in my use case (A(depends_on: B started) -> B(depends_on: C healthy) -> C):

  • B successfully waits for C to be healthy
  • A starts at the same time as C, when it should start after B

this change fixes the problematic behavior above.

@anmonteiro anmonteiro force-pushed the anmonteiro/wait-for-process-to-start branch from 40943dd to 5751e16 Compare March 2, 2024 23:19
@anmonteiro anmonteiro force-pushed the anmonteiro/wait-for-process-to-start branch from 5751e16 to a3dbdba Compare March 2, 2024 23:41
Copy link

sonarqubecloud bot commented Mar 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@F1bonacc1 F1bonacc1 merged commit 1a73f44 into F1bonacc1:main Mar 2, 2024
3 checks passed
@F1bonacc1
Copy link
Owner

Great!
Thanks!

@anmonteiro anmonteiro deleted the anmonteiro/wait-for-process-to-start branch March 2, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants