Tidy some tests up in order to update hypothesis #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify tests using the builtin operator module to remove some lambdas. Refactor all operator test cases so that the @given decorator is applied only to test methods - this removes the do_test* methods and lets Hypothesis work with the out of the box configuration.
Adding -v to test reporting and setting the PYTHONFAULTHANDLER environment variable in tox. This will enable better reporting of failures, even when the failure is a segfault.
|
Great, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to get #102 working I noticed that an intermittent segfault happening that was unclear on inspecting the logs. While investigating it seemed easy to update the test reporting and remove the upper bound pin on hypothesis, so here we are.
This PR refactors the test cases to make more recent hypothesis happy, and makes sure that all individual test cases being run are reported so even segfaults can be inspected.