feat: ingest-page and restructure of components to be more general#484
feat: ingest-page and restructure of components to be more general#484
Conversation
src/components/ingests-page/add-ingest-modal/add-ingest-form.tsx
Outdated
Show resolved
Hide resolved
| <DeviceTableHeaderCell>Label</DeviceTableHeaderCell> | ||
| <DeviceTableHeaderCell>Status</DeviceTableHeaderCell> | ||
| </DeviceTableHeader> | ||
| {deviceType === "deviceOutput" || deviceType === "deviceInput" |
There was a problem hiding this comment.
Is this necessary since deviceTypes is only ["deviceInput", "deviceOutput"]?
There was a problem hiding this comment.
Yes, the map() is acting on ingest and ingest[deviceType] need to make sure it's an "deviceInput" or "deviceOutput", because there are other properties on the ingest object.
| return ( | ||
| <> | ||
| <PageHeader title="Productions" loading={showRefreshing}> | ||
| {!isMobile && ( |
There was a problem hiding this comment.
Had a thought - is this something that should be unavailable for tablet users as well?
There was a problem hiding this comment.
If I remember correctly the discussion was that a tablet is large enough for people to "work on" so it feels reasonable to have it available for those users. We blocked it because we wanted to avoid accidental edits of production, a tablet is less likely to pose such a risk.
But when the possibility to add a security-layer is added, with admin-rights, we could remove the mobile-restriction altogether (the one not related to technical limitations).
src/components/ingests-page/add-ingest-modal/use-create-ingest.tsx
Outdated
Show resolved
Hide resolved
|
Based on discussion yesterday, with the Ingests-button on the landing page, we should rename the 'Create'-button to 'Create Production' for clarity on what you are creating. |
src/components/ingests-page/add-ingest-modal/use-create-ingest.tsx
Outdated
Show resolved
Hide resolved
| className?: string; | ||
| }; | ||
|
|
||
| export const CollapsibleItem = ({ |
malmen237
force-pushed
the
feat/ingest-page
branch
from
61818a3 to
70801fb
Compare
3 participants
New buttons to the different manage-pages, instead of "manage" there is "ingests" and "productions":
Manage ingests-page:
Saved ingests in collapable view and button to create new ingest
Expanded view:
Modal for creating new ingest:
Confirmation when deleting saved ingest:
If device-list is empty then a small text will inform the user: