Update & optimize

[dy]

Hello @mattdesl!

This is the lightweight version of #2.

Changes:

• Update tests to use [email protected]
• Process n×m dim canvas more carefuly
• Take fragment shader source as the only argument var draw = create(glslify('./shader.frag'), opts?). It is compatible with old API.
• Optimize performance of draw - it is 2-3 times faster in some cases now.
• Process float values by default, if possible, and fallback to Uint8 if not.

It is a major change, because float processing does not clamp values to 0..1 range now. In every other aspect it is minor change.

Looking forward for review.

[mattdesl]

Float32Array#map doesn't work in Safari and probably some other older browsers. 😄

[mattdesl]

Nice work!

I made a couple comments. The only weird thing for me is the API, which could be used in any of these ways:

create(shader)
create({ shader: shader })
create(shader, { shader: shader })
create(null, { shader: shader })

I think it's better to keep a smaller API surface area even if it introduces an extra few keystrokes. This way any code using this library is forced to be consistent:

create({ shader: shader })

😄

[mattdesl]

Small thing here – I think it's best to reduce the peer dependency on fragShader and gl-shader and just assume a more generic interface that is basically { gl, bind() } which is what we had before. 😄 But I think this part will go away if we keep the options simple as they were before.

[dy]

@mattdesl ok, fixed all comments.
I agree with the API consistency point, but I would stick to <process>(<what>, <how>?) scheme, which is create(shader, opts?) in this case. It sets UX to the first place and quite easy and intuitive to remember, user doesnt need to remind the options key for the shader: is it a shader, fragShader, etc. It’s not a big deal here though.

[mattdesl]

Yeah I agree create(shader, opt?) is better since shader is required. But we can remove it as an option from the opt param.

[mattdesl]

I can merge and fix the API to the new style though, and make a breaking change. Thanks for all this!

[dy]

Ok, great! I’ll then align nogl-shader-output then to comply with the new API.

[mattdesl]

Merged & cleaned up code / docs in 2.x. Thanks!