Add saved searches feature by johncschuster · Pull Request #304 · Expensify/k2-extension

johncschuster · 2026-02-07T04:10:40Z

Summary

Adds a saved searches feature to the K2 extension so users can save the current filter state (including title search), name it, and re-apply it later.

Changes

Title filter: Added optional titleFilter to the filter shape; filtering by issue title (case-insensitive) in PanelIssues and a "Search by title" input in the Filters form.
Storage: New ONYXKEYS.SAVED_SEARCHES and SavedSearchesStorage.js using chrome.storage.local for persistence.
Actions: New SavedSearches.js with getSavedSearches, saveSavedSearch, applySavedSearch, deleteSavedSearch, renameSavedSearch.
UI: In the Filters area: "Save search" button (prompts for name), and a "Saved searches" list with Apply, Rename, and Delete per item.
Dashboard: Re-enabled the Filters component in ListIssues so the filter form and saved searches are visible.
Fixes: applySavedSearch now waits for saveFilters when it returns a promise; componentDidUpdate in Filters syncs form fields when filters change (not only milestones) so applied saved searches update the UI correctly.

Made with Cursor

- Add title filter to issue filters (filterPropTypes, PanelIssues, Filters UI) - Add ONYXKEYS.SAVED_SEARCHES and SavedSearchesStorage (chrome.storage.local) - Add SavedSearches actions: get, save, apply, delete, rename - Add Save search button and Saved searches list (Apply/Rename/Delete) in Filters - Re-enable Filters component in dashboard ListIssues - Fix applySavedSearch to wait for saveFilters when async - Fix componentDidUpdate to sync form fields when filters change (not only milestones) Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot

Pull request overview

Adds a “saved searches” feature to the K2 dashboard so users can persist and re-apply filter presets (including a new title search filter) across sessions.

Changes:

Re-enabled the dashboard Filters UI and added a new “Search by title” field plus saved-search CRUD controls.
Introduced ONYXKEYS.SAVED_SEARCHES and new saved-search actions/storage for persistence via extension storage.
Added title-based filtering into PanelIssues (case-insensitive substring match).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/js/module/dashboard/ListIssues.js	Re-adds `Filters` to the dashboard layout.
src/js/module/dashboard/Filters.js	Adds title filter input and saved-search UI + Onyx connection.
src/js/lib/filterPropTypes.js	Extends filter shape with optional `titleFilter`.
src/js/lib/actions/SavedSearches.js	Implements saved-search CRUD and applying saved filters.
src/js/lib/SavedSearchesStorage.js	Adds persistence layer over extension storage.
src/js/component/panel/PanelIssues.js	Applies `titleFilter` when ordering/filtering issues.
src/js/ONYXKEYS.js	Adds `SAVED_SEARCHES` Onyx key.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-07T04:15:28Z

src/js/lib/SavedSearchesStorage.js

+import getBrowser from './browser';
+
+const STORAGE_KEY = 'k2_saved_searches';
+
+/**
+ * @returns {Promise<Array<{id: string, name: string, filters: Object, createdAt: number}>>}
+ */
+function getSavedSearches() {
+    const browser = getBrowser();
+    return new Promise((resolve) => {
+        browser.storage.local.get(STORAGE_KEY, (result) => {
+            const list = result && result[STORAGE_KEY];


./browser default export is the browser/chrome object (see other imports like messenger.js), but this file imports it as getBrowser and calls it as a function. That will throw at runtime. Import the browser object directly (e.g. import ksBrowser from './browser') and remove the function call, or change browser.js to export a function (but that would require updating existing call sites).

Copilot · 2026-02-07T04:15:28Z

src/js/component/panel/PanelIssues.js

+    // Apply title filter first (case-insensitive includes)
+    if (filters && filters.titleFilter && typeof filters.titleFilter === 'string') {
+        const query = filters.titleFilter.trim().toLowerCase();
+        if (query) {
+            preparedIssues = _.filter(preparedIssues, (item) => (
+                item.title && item.title.toLowerCase().indexOf(query) !== -1
+            ));
+        }
+    }
+
    // Apply filters
    if (applyFilters && filters && !_.isEmpty(filters)) {


titleFilter is applied even when applyFilters is false. applyFilters is documented as the switch to ignore dashboard filters for certain views, so this change makes those views still subject to filtering. Consider moving the title filter logic inside the existing if (applyFilters && filters ...) block (or otherwise explicitly tie it to applyFilters) so the "ignore filters" behavior remains consistent.

Suggested change

// Apply title filter first (case-insensitive includes)

if (filters && filters.titleFilter && typeof filters.titleFilter === 'string') {

const query = filters.titleFilter.trim().toLowerCase();

if (query) {

preparedIssues = _.filter(preparedIssues, (item) => (

item.title && item.title.toLowerCase().indexOf(query) !== -1

));

}

}

// Apply filters

if (applyFilters && filters && !_.isEmpty(filters)) {

// Apply filters (including optional title filter)

if (applyFilters && filters && !_.isEmpty(filters)) {

// Apply title filter first (case-insensitive includes)

if (filters.titleFilter && typeof filters.titleFilter === 'string') {

const query = filters.titleFilter.trim().toLowerCase();

if (query) {

preparedIssues = _.filter(preparedIssues, (item) => (

item.title && item.title.toLowerCase().indexOf(query) !== -1

));

}

}

Copilot · 2026-02-07T04:15:29Z

src/js/module/dashboard/Filters.js

@@ -50,6 +69,9 @@ class Filters extends React.Component {
        this.fieldTask.checked = this.props.filters.task;
        this.fieldFeature.checked = this.props.filters.feature;
        $(this.fieldMilestone).val(this.props.filters.milestone);
+        if (this.fieldTitleFilter) {
+            this.fieldTitleFilter.value = this.props.filters.titleFilter || '';
+        }
    }


The form inputs are uncontrolled and default to unchecked/empty, but componentDidUpdate bails out when filters is empty. With Filters now rendered on the dashboard, the UI will never reflect the default filter state (e.g. improvement/task/feature should likely start checked) until something writes to ONYXKEYS.ISSUES.FILTER. Consider initializing defaults on mount when filters are empty, or updating the fields with fallback defaults instead of returning early.

johncschuster · 2026-02-07T04:16:00Z

@neil-marcellini I have completely vibe-coded this and have no way to know if it's total rubbish. Feel free to pick it apart!

neil-marcellini

Hey @johncschuster, I'm glad to see you taking a shot at this! The first thing I would recommend is making sure that you test it out locally. It should be pretty easy to do that and it doesn't require setting up the VM.

Here are some instructions. They are AI generated, but hopefully they are pretty clear and you should be able to pass these to your AI to help you get set up.

Setup (one-time)

Install Node.js v20 if you don't have it. The easiest way is via nvm. Open Terminal and run:
```
curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.0/install.sh | bash
```
Close and reopen Terminal, then run:
```
nvm install 20
```

Clone the repo and check out your branch:

git clone https://github.com/Expensify/k2-extension.git
cd k2-extension
git checkout saved-searches-feature

Install dependencies:
```
npm install
```

Build the extension

Run the development build:

npm run web

This will create a dist/ folder with the built extension and keep watching for changes.

Load it in Chrome

Open Chrome and go to chrome://extensions
Enable Developer mode (toggle in the top-right corner)
Click Load unpacked
Select the dist/ folder inside your k2-extension directory
The K2 extension should now appear in your extensions list

Test the saved searches feature

Navigate to a GitHub repo's issues page (e.g., https://github.com/Expensify/App/issues)
Open the K2 extension panel
Test the title filter by typing in the "Search by title" field and clicking Apply
Save a search by clicking "Save search" and entering a name
Verify the saved search appears in the list
Click "Apply" on a saved search and verify filters update
Test "Rename" and "Delete" buttons
Close and reopen the panel — verify saved searches persist

neil-marcellini · 2026-02-12T18:56:19Z

Converting to a draft until it's ready for my review again.

melvin-bot bot assigned johncschuster Feb 7, 2026

johncschuster requested review from Copilot and neil-marcellini February 7, 2026 04:11

Copilot started reviewing on behalf of johncschuster February 7, 2026 04:12 View session

Copilot AI reviewed Feb 7, 2026

View reviewed changes

neil-marcellini requested changes Feb 9, 2026

View reviewed changes

neil-marcellini marked this pull request as draft February 12, 2026 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add saved searches feature#304

Add saved searches feature#304
johncschuster wants to merge 1 commit intomainfrom
saved-searches-feature

johncschuster commented Feb 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

johncschuster commented Feb 7, 2026

Uh oh!

neil-marcellini left a comment

Uh oh!

neil-marcellini commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

johncschuster commented Feb 7, 2026

Summary

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

johncschuster commented Feb 7, 2026

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Setup (one-time)

Build the extension

Load it in Chrome

Test the saved searches feature

Uh oh!

neil-marcellini commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants