Draft
Conversation
…h non-blocking queue
…(), stop on shutdown
…op redundant std headers/qualifiers
…fault 1400B datagrams, .so symbol
…own(), and adjust newline append
|
I see this code uses |
Contributor
|
I never reviewed this @coleaeason. Do you still want to do it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Implements first class support for a Metric Plugin in Bedrock. The metric plugin can be extended to support any arbitrary implementation of a metric sender or provider (statsd, telegraf, prometheus, etc). An example statsd provider is included but I plan to remove it and move it to a stand alone repo.
@tylerkaraszewski can you please review and give your thoughts? I don't love the global metric function but I am not sure what better option there is to implement this to allow it to add metrics from the whole stack. Attaching the metric recorder to the server allows plugins to also queue their own metrics.
Leaving this as WIP for now until we agree at least on the rough design.
Fixed Issues
Fixes GH_LINK
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes