issue-29: fixed missing STATUS from rest endpoint #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patduin
commented
Oct 30, 2017
| @@ -38,7 +39,7 @@ | |||
| private @NotBlank String remoteMetaStoreUris; | |||
| private @Valid MetastoreTunnel metastoreTunnel; | |||
| private @NotNull AccessControlType accessControlType = AccessControlType.READ_ONLY; | |||
| private transient @NotNull MetaStoreStatus status = MetaStoreStatus.UNKNOWN; | |||
| private transient @JsonProperty @NotNull MetaStoreStatus status = MetaStoreStatus.UNKNOWN; | |||
There was a problem hiding this comment.
The actual fix, the rest is test related. Explicitly setting it as a JsonProperty. Following: FasterXML/jackson-databind#1184
massdosage
approved these changes
Oct 30, 2017
| @@ -80,6 +80,12 @@ | |||
| <groupId>org.skyscreamer</groupId> | |||
| <artifactId>jsonassert</artifactId> | |||
| <scope>test</scope> | |||
| <exclusions> | |||
There was a problem hiding this comment.
Do you need to do this in order to prevent a conflicting version of Jackson being pulled in?
There was a problem hiding this comment.
The rest controller test prints a warning about two similar class in two different jars on the classpath. It Adviced to remove one for deterministic test sake :). I don't need to do this for the fix.
ddcprg
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #29