Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slice title to max 512 characters #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kewde
Copy link

@kewde kewde commented Dec 17, 2024

This PR truncates the title to 512 characters.

Copy link

@timlanahan timlanahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, this is going to force the title to always be trucated going out of the webview?

@kewde
Copy link
Author

kewde commented Dec 17, 2024

Yes, so the onMessageProp listeners also get the truncated value. The drawback though, is that we are forcing this on all WebView usecases.

const meta = validateMeta(extractMeta(nativeEvent));
onMessageProp?.({ ...meta, data });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants