feat(secp256k1): partially ported secp256k1 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kewde
commented
Feb 18, 2023
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| cmake_minimum_required(VERSION 3.4.1) | |||
|
|
|||
| include_directories(${CMAKE_SOURCE_DIR}/../../../../android/jni/include) | |||
kewde
force-pushed
the
kewde/port-secp256k1
branch
2 times, most recently
from
bca36be to
c2633ef
Compare
kewde
commented
Feb 18, 2023
| @@ -0,0 +1,43 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
kewde
commented
Feb 18, 2023
| @@ -0,0 +1,614 @@ | |||
| #ifndef _SECP256K1_ | |||
kewde
force-pushed
the
kewde/port-secp256k1
branch
from
c2633ef to
13fc43d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tried to actually test this at all but I can already list a bunch of issues:
libsecp256k1.build-ios-i386_iPhoneSimulator--with-ecmult-window. see original patch.--with-asm=armmight be worth testing--enable-module-schnorrsigmight be worth exploring to provide schnorr signing as well