feat: add signBuffer function #193
Conversation
feri42
requested review from
kewde,
diegomura,
mvayngrib and
sparten11740
as code owners
|
Concept ACK |
| } | ||
| } | ||
|
|
||
| async getPublicKey({ seedId, keyId }) { |
There was a problem hiding this comment.
do we have external consumers that need this or should we make it private for now?
There was a problem hiding this comment.
I thought it would be nice to have this function so that we don't need to use exportKey in places where we know we will never need the private keys or xpubs. Making it private will serve no purpose. I can remove it if it seems overkill.
There was a problem hiding this comment.
the current one is easy to use though:
const { publicKey } = await keychain.exportKey({ seedId, keyId })
// now we're adding this, which seems super similar
const publicKey = await keychain.getPublicKey({ seedId, keyId })not strongly opposed to adding it though
There was a problem hiding this comment.
The above is exactly the same. Only getPublicKey emphasizes we area only interested in the public key. And exportKey does cause xpubs to be transported over IPC, even if they are not used afterwards. Also, it is just too easy to add exportPrivate: true to exportKey. I just think it could improve security and readability.
There was a problem hiding this comment.
sounds good, let's keep it
Copy the signing function from tx-signer, so that we don't need that much keychain detail knowledge in tx-signer. Looking for Conept ACK (initially).