Skip to content

Conversation

@ApokalyptischerTempler
Copy link

@ApokalyptischerTempler ApokalyptischerTempler commented Feb 11, 2025

Implements solution for #251

…oading and encoding tracks.

Adds progress bar for processing URLs and downloading albums.
@Evolution0
Copy link
Owner

I had tqdm integrated at one point on my dev branch, I removed it when I cut down on dependencies.

I didn't feel like adding an additional dependency just for progress bars was worth it especially considering you have to go down to quite a low column count to cause issues with the progress bar (and even then you can detect that and cut down the bar length), and from experience the newline generation is dependent on what kind of terminal you are running in. For example I can squish my terminal down as small as possible in PyCharm and it just keeps on trucking, no newlines.

If it were to be added back in it would need to be an optional dependency.

Which would mean changing the way its integrated so that the default is the original implementation but if tqdm is installed use that instead, may need to separate progress bar handling into a function and do a simple try/except ImportError bit for tqdm in the init to set a var to true so that when the progress bar function is called you can switch between methods based on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants