Add occupancy mask #218
Merged
Add occupancy mask #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce angle conversions between degrees and radians Co-Authored-By: scotttimmins <[email protected]>
|
I've tested quite a bit and works amazing so far! Are you happy for this to be merged now after the small tweak? |
Yup! Had to reload the integration for the controls to move from the configuration to the controls, I supose it stored the last value entity_category had. |
|
Great, merging now. Created the feature for the mmwave configurator too add support for this in EverythingSmartHome/everything-presence-addons#9 |
EverythingSmartHome
merged commit 3d72165
into
EverythingSmartHome:main
60 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #204.
Still missing some documentation, I've tested and it seems to be working as intended. Both zone and global occupancies respect the mask, so anything inside it doesn't count towards being occupied.