Disable manufacturer update by default #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the new manufacturer update entity to disabled by default, so that it is hidden. This is due to many users getting confused at the difference between the ESPHome update entity and the new manufacturer update entity. This has caused them to overwrite their encryption key and thus Home Assistant isn't able to communicate with the device.
Until their is a better way to handle the manufacturer updates when an encryption key is set, I will disable it for now to not cause so much confusion.
It also removes the http_request timeout that was set in a previous version to help with an esphome bug. The timeout in ESPHome is now 4.5s by default.