Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable thumbnails when only single account logged in. #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

feyyd
Copy link

@feyyd feyyd commented Jun 9, 2023

Based off master branch, this feature disables thumbnails when only a single account is logged in.

Added an option to the main settings to enable/disable, default is disabled.

Currently a couple questions but should be easily resolved:

  1. How to handle accounts that are on character select screen, currently I am counting this as "logged in"
  2. Doing the check every tick and setting the enable/disable flag on each thumbnail. I didn't add a temp bool so we run only if changed, currently it just iterates through each thumbnail and sets the enable disable flag. Its performing this flag change every 500ms per character and only toggling a bool so I didn't overengineer it here.
  3. Please double check my option, this is the first time I've mucked with the UI, but I basically just copied how the other options were implemented.

feyyd added 2 commits June 9, 2023 10:21
Enable all thumbnails if more than one account.

--amend remove line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant