Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speaker Mentorship Signup due date has passed. #976

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

cybit
Copy link
Contributor

@cybit cybit commented Jan 24, 2025

Move the line in FAQ
Remove Form links from Link buttons.

Closes #975

@cybit cybit requested review from cmaureir and hypha January 24, 2025 12:39
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Preview available

Key Value
url https://ep2025-mentorship-closed.ep-preview.click
last update 2025-01-27T13:03:08.602Z

Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A wee comment.

Things not in diff:

  1. Do you want to do anything with the mentorship CTA? It is technically still correct there but if you have anything else to promo, it can then be replaced now.
  2. The second paragraph of the mentorship.mdx needs to change. It currently says At the moment we are looking for interested mentors who would like to help our mentees to create their proposals, and if accepted deliver their talk. If you are interested in helping mentees as their mentor, please register now.. You could either delete it or say something in the line of The Speaker Mentorship signups are now closed. we’re thrilled to have matched 44 mentees with 24 mentors from our community. A huge thank you to our mentors, and best of luck to the mentees — we can’t wait to see your submissions!

@@ -43,7 +43,7 @@ with your mentee to:
You will also be invited to join the panel of the Webinar Workshops.

<div class="text-center">
<ButtonLink href="https://forms.gle/Wbn9Z7zBQtK56xjS9">I would like to share my experience by being a "Mentor".</ButtonLink>
<ButtonLink href="#">Signup closed.</ButtonLink>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think it is nicer to use Button instead of ButtonLink here. So I'd go with
    <Button>Signup closed</Button>

  2. Also, I'd delete the period at the end because it's not a proper full sentence.

  3. In previous years, they put the button right below the heading, which might be slightly more informative. But it's up to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like in 2db92fb ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I don't like the look (CSS) of Button .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that one indeed. We can adapt the look of the button later, e.g. make it grey to indicate non-clickable. But I think it is annoying to use ButtonLinks with an empty URL that leads to nowhere in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was to make it work. Now the task is to make it right.

Copy link
Contributor

@hypha hypha Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to discuss how to make look better in another PR / issue so the content update doesn't get blocked?
Edit: Ofc Ege is already on it: #978

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #978

src/content/pages/programme/mentorship.mdx Outdated Show resolved Hide resolved
@clytaemnestra
Copy link
Contributor

Should we remove/update this one as well?

image

@cybit
Copy link
Contributor Author

cybit commented Jan 24, 2025

Should we remove/update this one as well?

If we have new things yes. But only having two looks odd.

@cybit cybit requested a review from hypha January 24, 2025 15:19
Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@cybit cybit merged commit d13bfd5 into ep2025 Jan 27, 2025
4 checks passed
@cybit cybit deleted the ep2025-mentorship-closed branch January 27, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update website to reflect the end of Speaker Mentorship signup.
4 participants