-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speaker Mentorship Signup due date has passed. #976
Conversation
Preview available
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A wee comment.
Things not in diff:
- Do you want to do anything with the mentorship CTA? It is technically still correct there but if you have anything else to promo, it can then be replaced now.
- The second paragraph of the mentorship.mdx needs to change. It currently says
At the moment we are looking for interested mentors who would like to help our mentees to create their proposals, and if accepted deliver their talk. If you are interested in helping mentees as their mentor, please register now.
. You could either delete it or say something in the line ofThe Speaker Mentorship signups are now closed. we’re thrilled to have matched 44 mentees with 24 mentors from our community. A huge thank you to our mentors, and best of luck to the mentees — we can’t wait to see your submissions!
@@ -43,7 +43,7 @@ with your mentee to: | |||
You will also be invited to join the panel of the Webinar Workshops. | |||
|
|||
<div class="text-center"> | |||
<ButtonLink href="https://forms.gle/Wbn9Z7zBQtK56xjS9">I would like to share my experience by being a "Mentor".</ButtonLink> | |||
<ButtonLink href="#">Signup closed.</ButtonLink> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I think it is nicer to use Button instead of ButtonLink here. So I'd go with
<Button>Signup closed</Button>
-
Also, I'd delete the period at the end because it's not a proper full sentence.
-
In previous years, they put the button right below the heading, which might be slightly more informative. But it's up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like in 2db92fb ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I don't like the look (CSS) of Button .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that one indeed. We can adapt the look of the button later, e.g. make it grey to indicate non-clickable. But I think it is annoying to use ButtonLinks with an empty URL that leads to nowhere in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea was to make it work. Now the task is to make it right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to discuss how to make look better in another PR / issue so the content update doesn't get blocked?
Edit: Ofc Ege is already on it: #978
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #978
If we have new things yes. But only having two looks odd. |
Co-authored-by: hypha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
Move the line in FAQ
Remove Form links from Link buttons.
Closes #975