Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added money editing options #430

Closed

Conversation

mimic2300
Copy link

@mimic2300 mimic2300 commented Apr 17, 2022

I think it would be good to be able to edit money as well :-)
A localization for all languages for the CEMoney key has also been added.

image

Damn... I accidentally committed localized comments in Resources.Designer.cs (I don't know how I did it) so you can ignore this file and add it manually

        public static string CEMoney {
            get {
                return ResourceManager.GetString("CEMoney", resourceCulture);
            }
        }

@hguy
Copy link
Collaborator

hguy commented Apr 19, 2022

Visual Studio 20XX regen automaticaly Resources.Designer.cs each time you update Resources.resx.
All *.Designer.cs should not be edited manually (except at merge time maybe).

@mimic2300
Copy link
Author

Visual Studio 20XX regen automaticaly Resources.Designer.cs each time you update Resources.resx. All *.Designer.cs should not be edited manually (except at merge time maybe).

So should I fix it or can you handle it? I would have to create a new PR for that.

@hguy
Copy link
Collaborator

hguy commented Apr 21, 2022

Visual Studio 20XX regen automaticaly Resources.Designer.cs each time you update Resources.resx. All *.Designer.cs should not be edited manually (except at merge time maybe).

So should I fix it or can you handle it? I would have to create a new PR for that.

I don't understand why you can't update your own PR ? Push a commit that fix your branch mimic2300:feature/gold_edit.

@mimic2300
Copy link
Author

Conflict fixed

@mimic2300
Copy link
Author

Moved to: #444

@mimic2300 mimic2300 closed this Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants