GH-880 Fix player placeholder in home admin.

[vLuckyyy]

Summary by CodeRabbit

• New Features

  • Enhanced home administration command with improved configuration and user notifications
  • Added more contextual information to home-related messages

• Refactor

  • Updated home command to use dynamic configuration for formatting
  • Improved user feedback in home management interactions

[coderabbitai]

Walkthrough

The pull request modifies the HomeAdminCommand class by introducing a new dependency PluginConfiguration to the constructor. This change allows for more configurable home-related functionality, specifically enhancing the way home names are formatted and displayed. The modification includes updating the constructor signature and integrating the new configuration parameter to provide more flexible formatting options for home-related notifications and listings.

Changes

File	Change Summary
eternalcore-core/src/main/java/com/eternalcode/core/feature/home/homeadmin/HomeAdminCommand.java	- Added PluginConfiguration as a constructor parameter - Updated constructor signature to include new dependency - Modified formattedListUserHomes method to use configuration-defined separator - Enhanced notice service placeholder usage with player name

Sequence Diagram

sequenceDiagram
    participant Admin
    participant HomeAdminCommand
    participant HomeManager
    participant PluginConfiguration
    participant NoticeService

    Admin->>HomeAdminCommand: Execute admin home command
    HomeAdminCommand->>PluginConfiguration: Retrieve configuration
    HomeAdminCommand->>HomeManager: Fetch user homes
    HomeManager-->>HomeAdminCommand: Return user homes
    HomeAdminCommand->>HomeAdminCommand: Format homes with config separator
    HomeAdminCommand->>NoticeService: Send formatted home list
    NoticeService-->>Admin: Display home list

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

eternalcore-core/src/main/java/com/eternalcode/core/feature/home/homeadmin/HomeAdminCommand.java (1)

140-143: Consider adding null safety and documentation.

While the configurable separator is a good improvement, consider these enhancements:

1. Add null safety for the separator
2. Add Javadoc explaining the format and configuration dependency

+    /**
+     * Formats the list of homes for the given user using the configured separator.
+     *
+     * @param uniqueId The UUID of the user
+     * @return A formatted string of home names
+     */
     private String formattedListUserHomes(UUID uniqueId) {
         return this.homeManager.getHomes(uniqueId).stream()
             .map(home -> home.getName())
-            .collect(Collectors.joining(this.pluginConfiguration.format.separator));
+            .collect(Collectors.joining(
+                Optional.ofNullable(this.pluginConfiguration.format.separator)
+                    .orElse(", ")
+            ));
     }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82256c5 and 01bbcc1.

📒 Files selected for processing (1)

• eternalcore-core/src/main/java/com/eternalcode/core/feature/home/homeadmin/HomeAdminCommand.java (7 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build (17)

🔇 Additional comments (2)

eternalcore-core/src/main/java/com/eternalcode/core/feature/home/homeadmin/HomeAdminCommand.java (2)

4-4: LGTM! Clean dependency injection implementation.

The addition of PluginConfiguration follows good practices:

• Proper dependency injection
• Immutable field
• Clean constructor parameter ordering

Also applies to: 28-38

---

58-58: LGTM! Consistent placeholder implementation.

The addition of player placeholders across all notifications improves context and user experience for admin operations.

Also applies to: 69-69, 89-89, 117-117, 135-135

[CitralFlo]

Minor change, merge it if tested